revert changes to _get / _set_wrapper in ParameterBase#5997
Merged
jenshnielsen merged 1 commit intomicrosoft:mainfrom Apr 24, 2024
Merged
revert changes to _get / _set_wrapper in ParameterBase#5997jenshnielsen merged 1 commit intomicrosoft:mainfrom
jenshnielsen merged 1 commit intomicrosoft:mainfrom
Conversation
This private api is used in zhinst qcodes https://github.com/zhinst/zhinst-qcodes/blob/main/src/zhinst/qcodes/qcodes_adaptions.py#L202
jenshnielsen
force-pushed
the
revert_get_set_wrapper
branch
from
55079fb to
5221622
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5997 +/- ##
=======================================
Coverage 67.42% 67.42%
=======================================
Files 349 349
Lines 30201 30201
=======================================
Hits 20364 20364
Misses 9837 9837 ☔ View full report in Codecov by Sentry. |
astafan8
approved these changes
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This private api is used in zhinst qcodes https://github.com/zhinst/zhinst-qcodes/blob/main/src/zhinst/qcodes/qcodes_adaptions.py#L202
This reverts an insignificant part of #5721